From: dizzy_at_roedu.net
Date: Tue 07 Oct 2003 - 08:18:05 BST
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi
Apllying patch-2.4.21ctx-17.gz from ftp://ftp.solucorp.qc.ca/pub/vserver/
makes 2.4.21 kernel not compile anymore (when not having IPv6 enabled).
The reason is obvios, please fix this thanks!
make[3]: Entering directory `/usr/src/linux-2.4.21/net/ipv4'
gcc -D__KERNEL__ -I/usr/src/linux-2.4.21/include -Wall -Wstrict-prototypes
- -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer
- -pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix
include -DKBUILD_BASENAME=udp -c -o udp.o udp.c
udp.c: In function `udp_v4_lookup_longway':
udp.c:239: warning: unused variable `score'
udp.c:245: `score' undeclared (first use in this function)
udp.c:245: (Each undeclared identifier is reported only once
udp.c:245: for each function it appears in.)
$ cd /usr/src/linux-2.4.21/net/ipv4
$ gcc -D__KERNEL__ -I/usr/src/linux-2.4.21/include -Wall
- -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
- -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686
- -nostdinc -iwithprefix include -DKBUILD_BASENAME=udp -E udp.c | less
The incriminating code is:
for(sk = udp_hash[hnum & (128 - 1)]; sk != ((void *)0) ; sk = sk->next)
{
if(sk->num == hnum && ! 0 ) {
int score;
}else if (sk->ip_info != ((void *)0) ){
if (udp_in_list (sk->ip_info,daddr)){
score++;
}else{
continue;
}
score = 1;
I would try to fix it myself but Im not a kernel developer and I am afraid
Ill make things worse, the patch part which brakes the code is:
*** 226,229 ****
- --- 241,250 ----
score = sk->family == PF_INET ? 1 : 0;
#else
+ }else if (sk->ip_info != NULL){
+ if (udp_in_list (sk->ip_info,daddr)){
+ score++;
+ }else{
+ continue;
+ }
score = 1;
#endif
***************
Thanks!
- ----------------------------
Mihai RUSU Email: dizzy_at_roedu.net
GPG : http://dizzy.roedu.net/dizzy-gpg.txt WWW: http://dizzy.roedu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)
iD8DBQE/gmivPZzOzrZY/1QRArjqAJ9zrpDNWgrrMOTCu2je1fFGQUjmiwCfQasU
2ewyFB+5oV+VPqvPDTPa3ag=
=Z+mU
-----END PGP SIGNATURE-----